Skip to content

core: services: ardupilot_manager: mavlink_proxy: Define missing self.log_path for MAVLinkServer #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaoantoniocardoso
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso commented Jun 1, 2025

Fixing this:
image

Which was a missing attribute definition from #3340 (my bad!).

Summary by Sourcery

Enhancements:

  • Add self.log_path initialization in MAVLinkServer.init

Copy link

sourcery-ai bot commented Jun 1, 2025

Reviewer's Guide

This PR fixes an AttributeError risk by defining the previously missing self.log_path attribute in the MAVLinkServer constructor, ensuring downstream methods can safely reference it.

File-Level Changes

Change Details Files
Initialize missing log_path attribute
  • Add self.log_path: Optional[str] = None in __init__
core/services/ardupilot_manager/mavlink_proxy/MAVLinkServer.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@joaoantoniocardoso joaoantoniocardoso changed the title core: services: ardupilot_manager: mavlink_proxy: Define missing self… core: services: ardupilot_manager: mavlink_proxy: Define missing selflog_path for MAVLinkServer Jun 1, 2025
@joaoantoniocardoso joaoantoniocardoso changed the title core: services: ardupilot_manager: mavlink_proxy: Define missing selflog_path for MAVLinkServer core: services: ardupilot_manager: mavlink_proxy: Define missing self.log_path for MAVLinkServer Jun 1, 2025
@patrickelectric patrickelectric merged commit f1ef471 into bluerobotics:master Jun 1, 2025
3 checks passed
@joaoantoniocardoso joaoantoniocardoso deleted the add_logs_to_mavlink_server branch June 1, 2025 00:44
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joaoantoniocardoso - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joaoantoniocardoso joaoantoniocardoso added the move-to-stable Needs to be cherry-picked and move to stable label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
move-to-stable Needs to be cherry-picked and move to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants