Skip to content

core: services: ardupilot_manager: mavlink_proxy: Save mavlink-server logs #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
Merged

core: services: ardupilot_manager: mavlink_proxy: Save mavlink-server logs #3340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c71e5d4
core: services: ardupilot_manager: mavlink_proxy: Save mavlink-server…
joaoantoniocardoso May 30, 2025
3ff21ee
core: services: ardupilot_manager: mavlink_proxy: Set log path for tests
joaoantoniocardoso May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/services/ardupilot_manager/mavlink_proxy/MAVLinkServer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ def convert_endpoint(endpoint: Endpoint) -> str:
filtered_endpoints = Endpoint.filter_enabled(self.endpoints())
endpoints = " ".join([convert_endpoint(endpoint) for endpoint in [master_endpoint, *filtered_endpoints]])

return f"{self.binary()} {endpoints}"
if not self.log_path:
self.log_path = "/var/logs/blueos/services/mavlink-server/"

return f"{self.binary()} {endpoints} --log-path={self.log_path}"

@staticmethod
def name() -> str:
Expand Down
1 change: 1 addition & 0 deletions core/services/ardupilot_manager/mavlink_proxy/test_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ async def serial_test_mavlink_server(
master_endpoints = create_endpoints_with_offset(valid_master_endpoints, 0)

mavlink_server = MAVLinkServer()
mavlink_server.log_path = "./logs"
assert mavlink_server.name() == "MAVLink-Server", "Name does not match."
assert re.search(r"\d+.\d+.\d+", str(mavlink_server.version())) is not None, "Version does not follow pattern."

Expand Down