frontend: App: Add new way to enter in dev mode #2754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add is dev mode setters and getters with new conditionals
* Add enter dev mode on 10 clicks in build date * Remove cloud unless in dev mode
joaomariolago
force-pushed
the
add-dev-secret-mode
branch
from
0b2587d to
1ce27cc
Compare
patrickelectric
requested changes
Jun 27, 2024
Comment on lines
+738
to
+741
| this.build_clicks = (this.build_clicks + 1) % 10 | ||
| if (this.build_clicks === 0) { | ||
| settings.is_dev_mode = true | ||
| } |
There was a problem hiding this comment.
Is there a reason for not doing something simpler ?
Suggested change
| this.build_clicks = (this.build_clicks + 1) % 10 | |
| if (this.build_clicks === 0) { | |
| settings.is_dev_mode = true | |
| } | |
| this.build_clicks += 1 | |
| settings.is_dev_mode = this.build_clicks > 10 |
There was a problem hiding this comment.
Just to keep consistent that if the user activate and deactivate the dev mode without refreshing it still will require 10 clicks and not only one in the second activation.
patrickelectric
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2751