core: libs: commonwealth: settings: pykson: Save in pretty json #2717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
force-pushed
the
add-pretty-json
branch
from
d8e5c82 to
c6d7595
Compare
patrickelectric
force-pushed
the
add-pretty-json
branch
from
c6d7595 to
79ffbef
Compare
| @@ -92,7 +92,7 @@ def save(self, file_path: pathlib.Path) -> None: | |||
|
|
|||
| with open(file_path, "w", encoding="utf-8") as settings_file: | |||
| logger.debug(f"Saving settings on: {file_path}") | |||
| settings_file.write(Pykson().to_json(self)) | |||
| settings_file.write(Pykson().to_json(self, base_indent=4)) | |||
There was a problem hiding this comment.
uhg, maybe our version doesn't have base_indent? Also, what is the difference between base_indent and indent?
There was a problem hiding this comment.
Thanks! But we have a fork of pykson (that does not include this feature) that is full of changes that are not merged and the project appears to be dead at the moment. We are moving to pydantic, and we should move all projects, removing pykson in the end. This just adds a minor quality for us when checking logs.
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
add-pretty-json
branch
from
79ffbef to
6572eff
Compare
joaomariolago
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #882