blueos_startup_update: add support for platform-specific patches #2643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Williangalvani
commented
May 30, 2024
Williangalvani
commented
patrickelectric
requested changes
May 30, 2024
| @@ -71,6 +72,32 @@ cmdline_file = None | |||
| import collections | |||
| from commonwealth.utils.commands import run_command | |||
|
|
|||
| class CpuType(str, Enum): | |||
| PI4 = "Raspberry Pi 4 (BCM2711)" | |||
| PI5 = "Raspberry Pi 5 (BCM2711)" | |||
| return HostOs.Bookworm | ||
| if 'bullseye' in os_release: | ||
| return HostOs.Bullseye | ||
| return HostOs.other |
There was a problem hiding this comment.
There is no definition for other, where are the linters ? 👀
There was a problem hiding this comment.
it is not working for blueos_startup_update because it doesn't have the .py extension >.<
even manually,.
let me see what I can do
Williangalvani
force-pushed
the
platform-specific
branch
5 times, most recently
from
3d909cc to
498ed1d
Compare
Williangalvani
force-pushed
the
platform-specific
branch
from
498ed1d to
992dfef
Compare
|
updated and re-tested: |
patrickelectric
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.