Commonwealth: create upload_file() #2642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
upload_file
branch
5 times, most recently
from
5447a9e to
9033bc2
Compare
Williangalvani
force-pushed
the
upload_file
branch
6 times, most recently
from
9f58511 to
88b5849
Compare
Williangalvani
requested review from
patrickelectric and
joaoantoniocardoso
and removed request for
patrickelectric
joaoantoniocardoso
approved these changes
Jun 3, 2024
| logger.warning("SSH key not found, falling back to password authentication") | ||
| ret = upload_file_with_password(temp_file_in_container, temp_file_in_host, check) | ||
| logger.debug(ret) | ||
| run_command(f"sudo mv {temp_file_in_host} {destination}") |
There was a problem hiding this comment.
I think we should only move if the (previous) command succeeds
Williangalvani
force-pushed
the
upload_file
branch
2 times, most recently
from
ce26d9c to
915f1e7
Compare
Williangalvani
force-pushed
the
upload_file
branch
from
915f1e7 to
6f4317d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current "echo" method can break files with
"Can be tested on my remote williangalvani/blueos-core:upload_file
just take something out of cmdline.txt or config.txt and restart the core container