Skip to content

Add force tag when deleting images in version chooser #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add force tag when deleting images in version chooser #2459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/services/versionchooser/utils/chooser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ async def delete_version(self, image: str, tag: str) -> web.StreamResponse:
# actually attempt to delete it
logger.info(f"Deleting image {image}:{tag}...")
try:
await self.client.images.delete(full_name, force=False, noprune=False)
await self.client.images.delete(full_name, force=True, noprune=False)
logger.info("Image deleted successfully")
return web.Response(status=200)
except Exception as e:
Expand Down