Add extra check for empty file input in version chooser manual upload #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomariolago
requested review from
Williangalvani,
patrickelectric and
joaoantoniocardoso
There was a problem hiding this comment.
Can we move alway from v-form ?
Reason: #2351
https://stackoverflow.com/questions/64995222/getting-a-ns-binding-aborted-error-for-simple-get-request
joaomariolago
force-pushed
the
fix-version-chooser-upload-manual
branch
2 times, most recently
from
68d479f to
7adcfa6
Compare
core/frontend/src/components/version-chooser/VersionChooser.vue
Outdated
Show resolved
Hide resolved
joaomariolago
force-pushed
the
fix-version-chooser-upload-manual
branch
from
7adcfa6 to
2958523
Compare
joaoantoniocardoso
approved these changes
Mar 7, 2024
patrickelectric
requested changes
Mar 7, 2024
core/frontend/src/components/version-chooser/VersionChooser.vue
Outdated
Show resolved
Hide resolved
patrickelectric
requested changes
Mar 7, 2024
* Add extra validation step to avoid calling upload function without any kind of file selected, this causes a small UI glitch because the visibility changes fast, now it should validate if there are files selected and inform user if needed
joaomariolago
force-pushed
the
fix-version-chooser-upload-manual
branch
from
2958523 to
9323ed0
Compare
patrickelectric
approved these changes
Mar 7, 2024
patrickelectric
added
the
merge-after-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.