core: libs: commonwealth: general: Add timeout for lsof operation #2420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested review from
Williangalvani,
joaoantoniocardoso and
joaomariolago
| return result.returncode == 0 | ||
| except Exception as error: | ||
| logger.error(f"Failed to check if file {path} is open, {error}") | ||
| return True |
There was a problem hiding this comment.
If timed out, the file is considered open.
just commenting so we think about the behavior we are choosing
patrickelectric
force-pushed
the
avoid-block
branch
from
4d28b2a to
960170c
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
avoid-block
branch
from
960170c to
f47bab5
Compare
joaoantoniocardoso
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the lsof operation that is blocking and using 100% of cpu in some cases.