Added unknown source frame handler #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for the contribution, the proposal is good, you just need to fix a couple of things:
|
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 74.78% 74.71% -0.08%
==========================================
Files 37 37
Lines 3903 3927 +24
==========================================
+ Hits 2919 2934 +15
- Misses 710 718 +8
- Partials 274 275 +1
Continue to review full report at Codecov.
|
aler9
force-pushed
the
main
branch
2 times, most recently
from
8e01c2c to
1411cb3
Compare
|
please rebase and reopen if you still need this feature. |
|
This issue is being locked automatically because it has been closed for more than 6 months. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using gortsplib in a scenario where the server is running inside a docker container. After RTSP negotiation UDP frames are coming from random ports so they are dropped in serverUDPListener run(). I have no control over the docker service so I can't turn off the userland-proxy option or use host networking in docker. I've managed to create a simple UDP matching mechanism based on NAT hole punching on the client-side and expecting new connections on the server side. Parsing RTP/RTCP frames I'm able to predict from which client/publisher the frame is coming from and modify SettupedTrack udp ports.
The problem is that currently, I need to modify serverudpl.go to inject this mechanism. If the library would have a built-in handler for frames coming from an unknown source it would be possible to make it from the connection handling layer.