Skip to content

Enable custom metrics in evaluate.py #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2017
Merged

Enable custom metrics in evaluate.py #809

merged 1 commit into from
Dec 30, 2017

Conversation

siddharth-agrawal
Copy link
Contributor

Fix for issue #771. Added a unit test inside test_evaluate.py to verify execution of custom metrics.

dustinvtran
dustinvtran approved these changes Dec 30, 2017
View reviewed changes
Copy link
Member

@dustinvtran dustinvtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and tested change. Thanks! callable indeed looks like it's supported for Python 2.7+ and 3.4+, which Edward is for.

@dustinvtran dustinvtran merged commit a58e159 into blei-lab:master Dec 30, 2017
@dustinvtran dustinvtran mentioned this pull request Dec 30, 2017
Closed
@siddharth-agrawal siddharth-agrawal deleted the custom_metric branch December 31, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinvtran dustinvtran dustinvtran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharth-agrawal @dustinvtran