Added sample_shape parameter to RandomVariable #591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that adds a keyword argument
sample_shape
to EdwardRandomVariable
s that gets passed to the underlyingtf.contrib.distributions
Distribution
's sample function. This lets us replace syntax like ed.Normal(mu=tf.ones([10, 1])*mu_vec, sigma=1.) with ed.Normal(mu=mu_vec, sigma=1., n=10).IMO, this is clearer, since it explicitly says that some slices are i.i.d., some are independent, and dependent. (
Distribution
keeps track of these withbatch_size
andevent_size
.) It's also (very marginally) more efficient, and it makes doing algebra on the graph a little easier in some cases.