add operator overloading to RandomVariable #445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many operators are overloaded for RandomVariable, following those available in
tf.Tensor
. The output is always atf.Tensor
. It operates on the sample tensor associated to the RandomVariable.For example, this lets us do
Remarks
__getitem__
method. That is, should we also return indexing from the sample tensor? Or should__getitem__
be the only method that returns a subset of the random variable? (If so, how do we do so efficiently?)eval()
be a method? E.g., callingx.eval()
would be easier thanx.value().eval()
which is almost always what the user intended. I think it should only be a method if we can also dosess.run(x)
somehow, and not requiresess.run(x.value())
.todo