Refactored is_diagram_supported_by_generators (#427)

Author: bkryza

src/common/generators/generators.cc

@@ -242,6 +242,35 @@ void generate_diagram(const std::string &name,
     }
 }
 
+bool is_diagram_supported_by_generators(
+    const std::vector<generator_type_t> &generators,
+    model::diagram_t diagram_type)
+{
+    for (const auto generator_type : generators) {
+        if (generator_type == generator_type_t::plantuml) {
+            if (generator_supports_diagram_type<plantuml_generator_tag>(
+                    diagram_type))
+                return true;
+        }
+        else if (generator_type == generator_type_t::json) {
+            if (generator_supports_diagram_type<json_generator_tag>(
+                    diagram_type))
+                return true;
+        }
+        else if (generator_type == generator_type_t::mermaid) {
+            if (generator_supports_diagram_type<mermaid_generator_tag>(
+                    diagram_type))
+                return true;
+        }
+        else if (generator_type == generator_type_t::graphml) {
+            if (generator_supports_diagram_type<graphml_generator_tag>(
+                    diagram_type))
+                return true;
+        }
+    }
+    return false;
+}
+
 int generate_diagrams(const std::vector<std::string> &diagram_names,
     config::config &config, const common::compilation_database_ptr &db,
     const cli::runtime_config &runtime_config,
@@ -274,31 +303,8 @@ int generate_diagrams(const std::vector<std::string> &diagram_names,
             continue;
 
         // If none of the generators supports the diagram type - skip it
-        bool at_least_one_generator_supports_diagram_type{false};
-        for (const auto generator_type : runtime_config.generators) {
-            if (generator_type == generator_type_t::plantuml) {
-                if (generator_supports_diagram_type<plantuml_generator_tag>(
-                        diagram->type()))
-                    at_least_one_generator_supports_diagram_type = true;
-            }
-            else if (generator_type == generator_type_t::json) {
-                if (generator_supports_diagram_type<json_generator_tag>(
-                        diagram->type()))
-                    at_least_one_generator_supports_diagram_type = true;
-            }
-            else if (generator_type == generator_type_t::mermaid) {
-                if (generator_supports_diagram_type<mermaid_generator_tag>(
-                        diagram->type()))
-                    at_least_one_generator_supports_diagram_type = true;
-            }
-            else if (generator_type == generator_type_t::graphml) {
-                if (generator_supports_diagram_type<graphml_generator_tag>(
-                        diagram->type()))
-                    at_least_one_generator_supports_diagram_type = true;
-            }
-        }
-
-        if (!at_least_one_generator_supports_diagram_type) {
+        if (!is_diagram_supported_by_generators(
+                runtime_config.generators, diagram->type())) {
             LOG_INFO("Diagram '{}' not supported by any of selected "
                      "generators - skipping...",
                 name);