[PM-24054] Update GUI build jobs to use nvmrc version #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
=========================================
+ Coverage 7.72% 12.62% +4.89%
=========================================
Files 68 68
Lines 2757 2757
Branches 477 477
=========================================
+ Hits 213 348 +135
+ Misses 2529 2381 -148
- Partials 15 28 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
eliykat
commented
Jul 23, 2025
| @@ -10,12 +10,14 @@ on: | |||
| - "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment | |||
| - "./openldap/**/*" # any change to test fixtures | |||
| - "./docker-compose.yml" # any change to Docker configuration | |||
| - "./package.json" # dependencies | |||
There was a problem hiding this comment.
Opportunistic change while I'm here. I noticed the integration tests weren't running when dependencies were upgraded, which is a good use case for them.
|
BTreston
approved these changes
Jul 24, 2025
eliykat
deleted the
ac/pm-24054/update-gui-build-workflow-to-use-nvmrc-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
In #817 I changed the build workflow to use the node version in
.nvmrc. However, I only updated the CLI build jobs, not the GUI build jobs, which are still using node 18. Electron ships with its own version of node so it doesn’t affect the node runtime in the artifact, but the build environment should be using a consistent version of node in all jobs.This PR updates the GUI build jobs to also use the correct version of node.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes