-
Notifications
You must be signed in to change notification settings - Fork 89
[PM-15456] Update AzureDirectoryService to dynamically select Graph API endpoint based on identity authority (public or government) #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…PI endpoint based on identity authority (public or government)
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
========================================
- Coverage 7.74% 7.73% -0.01%
========================================
Files 68 68
Lines 2751 2754 +3
Branches 473 474 +1
========================================
Hits 213 213
- Misses 2523 2526 +3
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
New Issues (8)Checkmarx found the following issues in this Pull Request
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15456
📔 Objective
This PR updates the Graph API URL to use the appropriate endpoint based on the selected Identity Authority. If Azure AD Government is selected, the URL now points to the government-specific endpoint (
https://graph.microsoft.us
) instead of the default public one (https://graph.microsoft.com
).⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes