Skip to content

[deps]: Update electron to v33 - abandoned #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 17, 2024
Merged

[deps]: Update electron to v33 - abandoned #658

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d17c9f5
[deps]: Update electron to v33
renovate[bot] Nov 8, 2024
e902a8e
remove event parameter from handler function params
BTreston Nov 15, 2024
162f3bc
change to v.32.1.1
BTreston Dec 17, 2024
382194b
Merge branch 'main' into renovate/electron-33.x
BTreston Dec 17, 2024
b7cb7ed
clean up
BTreston Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions jslib/electron/src/tray.main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,8 @@ export class TrayMain {
}

setupWindowListeners(win: BrowserWindow) {
win.on("minimize", async (e: Event) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Electron updated their type definitions for these event handler overloads. This overload's params were changed from accepting a Function definition to an arrow function with no parameters.

win.on("minimize", async () => {
if (await this.stateService.getEnableMinimizeToTray()) {
e.preventDefault();
this.hideToTray();
}
});
Expand Down
27 changes: 5 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"cross-env": "7.0.3",
"css-loader": "7.1.2",
"dotenv": "16.4.5",
"electron": "28.3.3",
"electron": "33.2.0",
"electron-builder": "24.13.3",
"electron-log": "5.2.0",
"electron-reload": "2.0.0-alpha.1",
Expand Down
Loading