Skip to content

Conversation

Ayowel
Copy link
Contributor

@Ayowel Ayowel commented Oct 10, 2025

Description of the change

This adds support for .Values.grafanaalloy.alloy.extraConfig in the chart's secret file as would be expected when reading the README.

Benefits

Allow users to customize their grafana-alloy as would be expected from the README

Possible drawbacks

Users that have needlessly configured an extraConfig value might be surprised (as it is not used at the moment unless the grafana-alloy subchart's secret is used - in which case this chart's secret is unused), however this is a case of excess/useless configuration that should be safe to ignore.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added grafana-loki triage Triage is needed labels Oct 10, 2025
@github-actions github-actions bot requested a review from carrodher October 10, 2025 20:52
@Ayowel Ayowel force-pushed the fix/loki-alloy branch 2 times, most recently from 09cf4ed to f2894af Compare October 10, 2025 21:02
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 14, 2025
@github-actions github-actions bot removed the triage Triage is needed label Oct 14, 2025
@github-actions github-actions bot removed the request for review from carrodher October 14, 2025 11:00
@github-actions github-actions bot requested a review from juan131 October 14, 2025 11:00
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this contribution! Please check my comments

Signed-off-by: Bitnami Bot <[email protected]>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan131 juan131 merged commit 98c8390 into bitnami:main Oct 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grafana-loki solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants