-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[bitnami/scylladb] Fix networkpolicy when use extraContainerPorts #36285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…entry instead of the extraContainerPorts entry Signed-off-by: dragonzeen <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!! thanks a lot @dragonzeen for taking care of this issue.
Checking your changes, I've just detected exactly the same issue in ingress
section, affecting also to jmxProxy.extraContainerPorts
(some lines below your current change):
charts/bitnami/scylladb/templates/networkpolicy.yaml
Lines 61 to 68 in 5c2c475
{{- range .Values.extraContainerPorts }} | |
- port: {{ . }} | |
{{- end }} | |
{{- if .Values.jmxProxy.enabled }} | |
- port: {{ .Values.containerPorts.jmx }} | |
{{- range .Values.jmxProxy.extraContainerPorts }} | |
- port: {{ . }} | |
{{- end }} |
Would you mind apply the same change there?
…entry instead of the extraContainerPorts entry in ingress section Signed-off-by: dragonzeen <[email protected]>
…onzeen/bitnami-charts into feature/scylladb/extra-port
Signed-off-by: Bitnami Bot <[email protected]>
I updated same issue in ingress section. |
Description of the change
Fixed the invalid handling of the .extraContainerPorts values in the generated NetworkPolicy
Benefits
The NetworkPolicy no longer errors when the extraContainerPorts is defined
Possible drawbacks
None
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm