Skip to content

Conversation

dragonzeen
Copy link

@dragonzeen dragonzeen commented Sep 23, 2025

Description of the change

Fixed the invalid handling of the .extraContainerPorts values in the generated NetworkPolicy

Benefits

The NetworkPolicy no longer errors when the extraContainerPorts is defined

Possible drawbacks

None

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

…entry instead of the extraContainerPorts entry

Signed-off-by: dragonzeen <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 23, 2025
@github-actions github-actions bot removed the triage Triage is needed label Sep 23, 2025
@github-actions github-actions bot removed the request for review from carrodher September 23, 2025 13:58
@github-actions github-actions bot requested a review from gongomgra September 23, 2025 13:58
@fmulero fmulero self-assigned this Oct 3, 2025
@fmulero fmulero self-requested a review October 3, 2025 08:12
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!! thanks a lot @dragonzeen for taking care of this issue.

Checking your changes, I've just detected exactly the same issue in ingress section, affecting also to jmxProxy.extraContainerPorts (some lines below your current change):

{{- range .Values.extraContainerPorts }}
- port: {{ . }}
{{- end }}
{{- if .Values.jmxProxy.enabled }}
- port: {{ .Values.containerPorts.jmx }}
{{- range .Values.jmxProxy.extraContainerPorts }}
- port: {{ . }}
{{- end }}

Would you mind apply the same change there?

dragonzeen and others added 3 commits October 10, 2025 17:17
…entry instead of the extraContainerPorts entry in ingress section

Signed-off-by: dragonzeen <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
@dragonzeen
Copy link
Author

Good catch!! thanks a lot @dragonzeen for taking care of this issue.

Checking your changes, I've just detected exactly the same issue in ingress section, affecting also to jmxProxy.extraContainerPorts (some lines below your current change):

{{- range .Values.extraContainerPorts }}
- port: {{ . }}
{{- end }}
{{- if .Values.jmxProxy.enabled }}
- port: {{ .Values.containerPorts.jmx }}
{{- range .Values.jmxProxy.extraContainerPorts }}
- port: {{ . }}
{{- end }}

Would you mind apply the same change there?

I updated same issue in ingress section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-progress scylladb verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bitnami/scylladb] Error occurred generated networkpolicy when use extraContainerPorts

5 participants