Skip to content

Conversation

james-mchugh
Copy link
Contributor

Description of the change

  • Adds ability to configure environment variables for the Prometheus Thanos container.
  • Adds ability to use templating in the secret name used for Thanos' storage config secret

Benefits

Users can mount secrets via environment variables to the container, enabling setting environment variables like AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to securely mount existing secrets in the cluster to the container.

Additionally, the secret name supporting templating is a common pattern for many secret and configmap names. It allows for dynamic configurations of the secret name, which is often useful for umbrella charts that may wrap this chart.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

bitnami-bot and others added 2 commits September 12, 2025 21:28
Signed-off-by: Bitnami Bot <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Sep 16, 2025
@github-actions github-actions bot removed the triage Triage is needed label Sep 16, 2025
@github-actions github-actions bot removed the request for review from javsalgar September 16, 2025 07:31
@github-actions github-actions bot requested a review from alvneiayu September 16, 2025 07:31
Signed-off-by: Bitnami Bot <[email protected]>
Copy link

github-actions bot commented Oct 2, 2025

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Oct 2, 2025
@james-mchugh
Copy link
Contributor Author

Sorry to ping you @javsalgar and @alvneiayu, but please let me know if there is anything I can do to help get this PR merged sooner.

@github-actions github-actions bot removed the stale 15 days without activity label Oct 3, 2025
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-progress prometheus stale 15 days without activity verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants