BIP374: remove debug print from test runner #1920
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
changed the title
jonatack
reviewed
Aug 9, 2025
There was a problem hiding this comment.
LGTM, but needs approval from a BIP author: @andrewtoth, @RubenSomsen, @theStack WDYT?
| @@ -23,7 +23,6 @@ | |||
| next(reader) | |||
| for row in reader: | |||
| (index, point_G_hex, seckey_a_hex, point_B_hex, aux_rand_hex, msg_hex, result_str, comment) = row | |||
| print(seckey_a_hex) | |||
There was a problem hiding this comment.
The test runner output is indeed more clear and consistent after this change.
jonatack
added
the
Pending acceptance
theStack
approved these changes
Aug 9, 2025
jonatack
removed
the
Pending acceptance
|
Thanks @theStack 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove leftover debug print statement that was printing private keys(seckey_a_hex) to console during test execution. Improves test output readability and consistency.