Skip to content

Conversation

tlvu
Copy link

@tlvu tlvu commented May 22, 2020

This PR fixes #61.

This PR is a continuation of PR #85.

Raven PR Ouranosinc/raven#276 matching this PR.

Changes:

  • Added documentation to use cruft initially to generate the project and after the fact to keep project in sync with cookiecutter template update.

  • Fix missing bump version config for new .cruft.json file.

  • Prevent merge conflicts on future cookiecutter template refresh in requirements_dev.txt.

  • Add make test-notebooks to TravisCI.

@tlvu tlvu requested review from huard and cehbrecht May 22, 2020 15:53
tlvu added 2 commits May 22, 2020 15:44
conda env create --quiet --name refresh-cookiecutter-template-using-cruft --file environment-docs.yml
Collecting package metadata: ...working... done
Solving environment: ...working... failed

ResolvePackageNotFound:
  - pywps[version='>=4.2']
  - nbsphinx
tlvu added a commit to Ouranosinc/raven that referenced this pull request May 25, 2020
Refresh cookiecutter template.

To get changes from this cookiecutter PR bird-house/cookiecutter-birdhouse#87
@tlvu tlvu merged commit 10a6888 into master May 25, 2020
@tlvu tlvu deleted the doc-how-to-use-cruft branch May 25, 2020 16:01
@tlvu
Copy link
Author

tlvu commented May 25, 2020

@cehbrecht Sorry have not waited for your review, if you find anything, please open an issue and I'll fix in another PR. I will still be working on improving, harmonizing the cookiecutter with all the existing birds this week.

I need to merge this PR because Raven depends on this PR, else cruft update in Raven will fail.

Quick question, I know Emu is used for testing but there is also Babybird. Is it worth keeping Babybird up-to-date with the cookiecutter? What is the different between Emu and Babybird?

@cehbrecht
Copy link
Member

@tlvu thanks for adding the doc and updating the birds :) The babybird is just the bird generated by the cookiecutter with default parameters ... it is just there for documentation purposes ... maybe we don't need it anymore.

@tlvu
Copy link
Author

tlvu commented May 26, 2020

maybe we don't need it anymore

@cehbrecht
Should I remove Babybird from the cookiecutter documentation?

@cehbrecht
Copy link
Member

@tlvu yes, I think we can retire the babybird ... it can be generated locally and we don't need to update the github repo.

tlvu added a commit to bird-house/finch that referenced this pull request May 27, 2020
…-using-cruft

Refresh cookiecutter template using cruft.

This PR is part of issue bird-house/cookiecutter-birdhouse#61, rolling out cruft as a mechanism to easily update cookiecutter template changes to existing project.

Requires PR bird-house/cookiecutter-birdhouse#87 and bird-house/cookiecutter-birdhouse#88.

Other noticeable changes in this PR:
* fix weird version format cb63d07
* fix flakes8 failure E741 ambiguous variable name 'l' 76345b9 + 7a312f1

RtD build passed with list of processes https://readthedocs.org/projects/finch/builds/11131993/
Zeitsperre pushed a commit to Ouranosinc/raven that referenced this pull request Aug 17, 2023
Refresh cookiecutter template.

To get changes from this cookiecutter PR bird-house/cookiecutter-birdhouse#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to update existing birds with latest from Cookiecutter template?
3 participants