get version number without importing package #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidcaron Thanks. Do you think we should set The original cookiecutter didn't do this ... but it seems to work now and we can skip some redundancy. |
|
@davidcaron done. Thanks :) |
Zeitsperre
pushed a commit
that referenced
this pull request
Jan 5, 2021
* get version number without importing package see: https://packaging.python.org/guides/single-sourcing-package-version * add note to __version__.py * don't repeat author and email information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes
pip installfor the module. When runningsetup.py, the dependencies are not yet installed so the module can't be imported when we want to get the version number.Related Issue / Discussion
bird-house/emu#67
Additional Information
https://packaging.python.org/guides/single-sourcing-package-version