Skip to content

Conversation

ematipico
Copy link
Member

Summary

Test Plan

Docs

Copy link

changeset-bot bot commented Sep 9, 2025

⚠️ No Changeset found

Latest commit: 91342b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates version metadata for two lint rules. In crates/biome_js_analyze/src/lint/nursery/no_jsx_literals.rs, the NoJsxLiterals rule’s version is set from "next" to "2.2.4". In crates/biome_json_analyze/src/lint/nursery/no_duplicate_dependencies.rs, the NoDuplicateDependencies rule’s version is set from "next" to "2.2.4". No behavioural logic or diagnostics are altered; only the declared version fields in the lint rule metadata are modified.

Possibly related PRs

Suggested labels

A-Linter, L-JavaScript, L-JSON

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 755ea73 and 91342b4.

📒 Files selected for processing (2)
  • crates/biome_js_analyze/src/lint/nursery/no_jsx_literals.rs (1 hunks)
  • crates/biome_json_analyze/src/lint/nursery/no_duplicate_dependencies.rs (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/version-rules

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico merged commit 3b5377f into main Sep 9, 2025
27 of 28 checks passed
@ematipico ematipico deleted the chore/version-rules branch September 9, 2025 10:32
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages labels Sep 9, 2025
Copy link

codspeed-hq bot commented Sep 9, 2025

CodSpeed Performance Report

Merging #7449 will not alter performance

Comparing chore/version-rules (91342b4) with main (755ea73)

Summary

✅ 133 untouched benchmarks

kedevked pushed a commit to kedevked/biome that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant