This repository was archived by the owner on Aug 15, 2025. It is now read-only.
fix: syntax issues causing compilation errors #792
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for all basic integer types
… feature combinations
CI was currently broken for two reasons
trunk was not compliant with the 1.41 MSRV check
clippy had new warnings
Since bincode 2.0 is not even in alpha yet MSRV should not be locked in place. This PR removes the MSRV checks for now. Additionally the few clippy warnings have been resolved.
It will be helpful to point users of the library to code examples that will work for them.
* Update virtue requirement from 0.0.17 to 0.0.18 Updates the requirements on [virtue](https://github.com/bincode-org/virtue) to permit the latest version. - [Release notes](https://github.com/bincode-org/virtue/releases) - [Commits](bincode-org/virtue@v0.0.17...v0.0.18) --- updated-dependencies: - dependency-name: virtue dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Fixed new lint warning --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Victor Koenders <[email protected]>
* Fix CI and clippy * Fix CI * Disable code coverage
…g#741) * Finally got around to updating the spec based on feedback * Fixed failing spec test
…code-org#729) * Expose types implementing serde::Deserializer * Gate IoReader import
Add an optional context for decoding allowing additional data to be passed to decoded structs. --------- Co-authored-by: branchseer <[email protected]>
Prepare for 2.0.0 stable release --------- Co-authored-by: Zoey Riordan <[email protected]>
Updates the requirements on [unty](https://github.com/bincode-org/unty) to permit the latest version. - [Commits](bincode-org/unty@v0.0.3...v0.0.4) --- updated-dependencies: - dependency-name: unty dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use qualified path for Result::Ok in bincode_derive * add test
* derive Debug for marker types - this will also implement Debug for the derived Configuration type * migrate to marker structs without fields
* Update error.rs * Update read.rs
Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version. - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.5.0...0.6.0) --- updated-dependencies: - dependency-name: criterion dependency-version: 0.6.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Trangar <[email protected]>
| }, | ||
|
|
||
| /// The encoder tried to encode a `Mutex` or `RwLock`, but the locking failed | ||
| /// The encoder tried to encode a `Mutex` or RwLock`, but the locking failed |
There was a problem hiding this comment.
Why is this ` removed?
src/error.rs
Outdated
|
|
||
| impl core::fmt::Display for DecodeError { | ||
| fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { | ||
| // TODO: Improve this? |
There was a problem hiding this comment.
Why was this TODO removed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
49 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i've gone through the code and corrected all instances of extra commas and improperly closed quotes that were triggering the
expected item, found ','error. the Rust syntax is now clean, and the project compiles successfully.