client: Add a generic Secret type #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
force-pushed
the
bilelmoussaoui/secret
branch
from
2dcc366 to
37e6983
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/secret
branch
8 times, most recently
from
01e89f6 to
c31e34a
Compare
Owner
Author
|
I guess before we merge this, we should investigate if it is ok to store the content-type as an attribute. If that is the case, we can also make use of that in the portal backend implementation as it would also be relevant for the server side implementation. |
Owner
Author
|
gnome-keyring-daemon never stores or cares about the content-type, on the other hand, kwallet stores it in an attribute https://invent.kde.org/frameworks/kwallet/-/blob/master/src/runtime/kwalletd/kwalletfreedesktopcollection.h#L16 named I guess we should store it as well, maybe named differently with a fallback for Kwallet use case |
bilelmoussaoui
force-pushed
the
bilelmoussaoui/secret
branch
from
c31e34a to
435115e
Compare
warusadura
reviewed
Nov 4, 2024
Avoids the duplicated types we have all over the place. - We still don't make use of the content-type when creating or retrieving portal secrets - We still don't make use of content-type when retrieving dbus items But it is an improvement over the current status. Fixes #133
Share the same code as the portal key
Makes uses of the content-type from the DBus API and just hack around for the portal backend until we figure out whether it makes sense to store the content-type as an attribute
bilelmoussaoui
force-pushed
the
bilelmoussaoui/secret
branch
from
435115e to
3fbbf46
Compare
Owner
Author
|
Merging for now, we can add content-type storage as an attribute later on as it wouldn't conflict with the changes done in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.