Skip to content

Fix scroll legend under Mac OS #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2018

Conversation

McGiverGim
Copy link
Member

Fixes #213

I think this will work for Mac too, in my windows systems it works perfectly and now I can scroll with the wheel mouse.

What I'm not too sure is about the keys used, in Windows they are perfect, but I don't know if Mac needs other.

image

Please test this version to see how it behaves in Mac.

@etracer65
Copy link
Member

Well it mostly works on Mac. The scrolling seems somewhat intermittent as it seems like there are certain spots in the legend where it won't work - not sure which elements. The mouse will be in the legend and scrolling won't work, move the mouse a little and it will start working. Can't really consistently replicate but it happens pretty frequently.

Also "ctrl + scroll" can be problematic on Mac as this combination is commonly used for zooming the entire screen. But I don't see that as a deal breaker. Also the equivalent to "alt + scroll" on Mac is "option + scroll" (it works fine to adjust expo).

Note that I was testing with the app running in Chrome - not the standalone version. I'm not currently set up to build the standalone.

@McGiverGim
Copy link
Member Author

Ok, I will recheck to see if I have forgotten some tag.

@McGiverGim
Copy link
Member Author

I have been trying to reproduce the intermittent behaviour (but under Windows) without luck.

There were two problems:

  • Mac OS hides by default scrollbar until the wheel is used.
  • The Blackbox intercepted the wheel, under ALL operating systems.

With this fix:

  • The scrollbar appears under Mac OS (first problem fixed)
  • It does not intercept the wheel. Under Windows the wheel works perfectly and in theory it must work exactly in the same manner for other OS.

Maybe I'm not reproducing it in the right manner. Some idea?

@mikeller mikeller added this to the 3.1.0 milestone Jul 7, 2018
@mikeller mikeller merged commit 85cd0f3 into betaflight:master Jul 8, 2018
@McGiverGim McGiverGim deleted the fix_scroll_mac branch July 18, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants