Skip to content

Fix manual protocol selection #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 26, 2025
Merged

Fix manual protocol selection #4554

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
447d1e4
Fix manual protocol selection
haslinghuis Jul 25, 2025
6650513
Check both tcp and ws protocol
haslinghuis Jul 25, 2025
c15a019
Improve check
haslinghuis Jul 25, 2025
c709f8e
Improve check v2
haslinghuis Jul 25, 2025
57a955f
Use test instead of exec
haslinghuis Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/serial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class Serial extends EventTarget {
if (portPath === "virtual") {
console.log(`${this.logHead} Using virtual protocol (based on port path)`);
newProtocol = this._virtual;
} else if (portPath === "manual") {
} else if (portPath === "manual" || /^(tcp|ws):\/\/([A-Za-z0-9.-]+)(?::(\d+))?$/.exec(portPath)) {
console.log(`${this.logHead} Using websocket protocol (based on port path)`);
newProtocol = this._webSocket;
} else if (portPath.startsWith("bluetooth")) {
Expand Down