Corrected when analytics is being sent

[blckmn]

• this is due to the data coming in later

TODO: will move more to async / await calls

Summary by CodeRabbit

• Refactor
  • Improved the reliability and sequencing of configuration tracking and build processing for flight controllers.
  • Enhanced asynchronous handling to ensure smoother and more predictable operations.

[coderabbitai]

Walkthrough

An asynchronous function sendConfigTracking was introduced to handle tracking events for flight controller configurations, using a SHA1 hash of the device identifier. Tracking logic was moved from processBoardInfo to processUid, and asynchronous control flow was established for configuration tracking and build processing by awaiting relevant functions.

Changes

File(s)	Change Summary
src/js/serial_backend.js	Added async sendConfigTracking function; moved and refactored tracking logic; updated processUid, processBuildOptions, and processBuildConfiguration to use async/await for sequencing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Preview URL: https://2718188b.betaflight-configurator.pages.dev

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/js/serial_backend.js (1)

83-96: Remove unnecessary async keyword or add proper async operations.

The function is declared as async but contains no await operations. Since tracking.sendEvent appears to be synchronous, the async keyword is unnecessary.

-async function sendConfigTracking() {
+function sendConfigTracking() {
     tracking.sendEvent(tracking.EVENT_CATEGORIES.FLIGHT_CONTROLLER, "Loaded", {
         boardIdentifier: FC.CONFIG.boardIdentifier,
         targetName: FC.CONFIG.targetName,
         boardName: FC.CONFIG.boardName,
         hardware: FC.CONFIG.hardwareName,
         manufacturerId: FC.CONFIG.manufacturerId,
         apiVersion: FC.CONFIG.apiVersion,
         flightControllerVersion: FC.CONFIG.flightControllerVersion,
         flightControllerIdentifier: FC.CONFIG.flightControllerIdentifier,
         mcu: FC.CONFIG.targetName,
         deviceIdentifier: CryptoES.SHA1(FC.CONFIG.deviceIdentifier).toString(),
     });  
 }

The implementation correctly sends comprehensive configuration data and properly hashes the deviceIdentifier for privacy.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ef9acb and 2718188.

📒 Files selected for processing (1)

• src/js/serial_backend.js (4 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/js/serial_backend.js (2)

src/js/Analytics.js (1)

• tracking (7-7)

src/js/fc.js (1)

• FC (130-993)

🔇 Additional comments (3)

src/js/serial_backend.js (3)

508-508: Good async/await implementation.

Adding await ensures proper sequencing of the asynchronous processCraftName() call.

---

521-521: Proper async sequencing maintained.

The await ensures processBuildOptions() completes before the function returns, maintaining correct asynchronous flow.

---

531-532: Excellent timing fix for analytics data availability.

Moving the tracking call to processUid after UID retrieval ensures the deviceIdentifier is available before sending analytics, which addresses the core issue described in the PR objectives.

The await processBuildConfiguration() properly maintains async sequencing. However, if sendConfigTracking() is made synchronous (as suggested in the earlier comment), then line 531 should be updated accordingly:

-    await sendConfigTracking();    
+    sendConfigTracking();