Skip to content

Refactor auto-backup in flashing tab for PWA #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2024
Merged

Refactor auto-backup in flashing tab for PWA #4005

merged 3 commits into from
Jun 5, 2024

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 11.0 milestone Jun 4, 2024
@haslinghuis haslinghuis self-assigned this Jun 4, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 864305e
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66603b23ab93a50008608b4c
😎 Deploy Preview https://deploy-preview-4005.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis force-pushed the auto-backup branch 2 times, most recently from 790175f to 1f12f0c Compare June 4, 2024 22:08
@haslinghuis haslinghuis mentioned this pull request Jun 4, 2024
Open
53 tasks
@haslinghuis haslinghuis changed the title Make auto-backup while flashing work for PWA Refactor auto-backup in flashing tab for PWA Jun 4, 2024
@haslinghuis haslinghuis force-pushed the auto-backup branch 6 times, most recently from 208513b to dfec164 Compare June 4, 2024 23:10
McGiverGim
McGiverGim requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to see refactors :)

Having timeouts it's not the best option, but I suppose it's the easiest at this point. Maybe we can try to remove them in a future refactor.

@haslinghuis haslinghuis requested a review from McGiverGim June 5, 2024 06:32
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nerdCopter
Copy link
Member

864305e6, yarn dev

  • the flashing's Create Backup button worked.

@haslinghuis haslinghuis merged commit 0ada2ce into betaflight:master Jun 5, 2024
@haslinghuis haslinghuis deleted the auto-backup branch June 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
PWA RN: REFACTOR
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @nerdCopter @McGiverGim