Skip to content

update gulp version to 4.0 #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update gulp version to 4.0 #1475

wants to merge 1 commit into from

Conversation

@immartian
Copy link

some issues including #1411 are all related to unsupported gulp v3.x, so changed the least version to v4.0.0 to assure the binding of several packages including Prism and Node-sass.

tested on both node v11.x and v12.x.

@immartian
Copy link
Author

Without this change, the current code base will not be able to run, most probably showing such errors:

Aborted
npm ERR! code ELIFECYCLE
npm ERR! errno 134
npm ERR! [email protected] postinstall: `gulp build-prism`
npm ERR! Exit status 134
npm ERR! 
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@ProbablyFaiz
Copy link

+1, this fixed my local instance which was previously showing that 134 code you posted above.

@jernejcvek jernejcvek mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@immartian @ProbablyFaiz