Add INIReader Sections and Keys methods #186
Conversation
There was a problem hiding this comment.
Per comments below, I won't be adding SetValue, but I'm open to adding Sections and Keys -- thanks.
Could you also please add an example/test of each of these methods in https://github.com/benhoyt/inih/blob/master/examples/INIReaderExample.cpp (and update the cpptest.txt output so CI passes). Something like:
Sections and keys:
- protocol: version
- user: active, email, name, pi, trillion
cpp/INIReader.cpp
Outdated
| @@ -109,6 +109,32 @@ bool INIReader::GetBoolean(const string& section, const string& name, bool defau | |||
| return default_value; | |||
| } | |||
|
|
|||
| void INIReader::SetValue(const std::string& section, const std::string& name, const std::string& value) { | |||
There was a problem hiding this comment.
Hi there, thanks for the contribution! I'm not going to add setting/writing functionality to inih or INIReader, so I'm afraid I'm not going to be adding this method. However, I'm willing to consider Sections and Keys -- I'll discuss those below.
Co-authored-by: Ben Hoyt <[email protected]>
|
Looks like tests are failing, too. See https://github.com/benhoyt/inih/actions/runs/13603098149/job/38031412682?pr=186 |
|
i actually needed the SetValue function and will be very useful for other users also so I will still request you to keep SetValue function but if you don't then no worry i will make a subclass for my usecase and I am happy to contribute |
Yep, you'll need to subclass for that, sorry. |
|
Ok thanks for your quick review and now the test hopefully will work fine and I think you can remove the SetValue function as you said you will not keep it so i just want to inform that editing by maintainers is enabled for this pr so you can remove the SetValue function easily. |
|
do you know why is it failing because it is not outputing any error message so I can't find what actually causing the error |
|
finally fixed the issue actually before I thought that it is failed when compiling but when actually I saw it carefully then i understand that it is trying find any difference between the printed message and cpptest.txt so now i fixed the issue lol |
benhoyt
changed the title
|
Thanks for the contribution! |
This PR adds a SetValue function to the INIReader class, allowing users to modify INI values.