r61: The left operand of '!=' is a garbage value

[DimitriPapadopoulos]

After updating the copy of inih bundled witch ocserv from r60 to r61, the static analyzer job in CI started complaining:

inih/ini.c:168:56: warning: The left operand of '!=' is a garbage value [core.UndefinedBinaryOperatorResult]
  168 |         if (offset == max_line - 1 && line[offset - 1] != '\n') {
      |                                       ~~~~~~~~~~~~~~~~ ^

This code was introduced by #188.

I must admit I haven't found the time to look into this static analysis issue yet, I'm creating an issue here so that I don't forget about it and for your information.

[DimitriPapadopoulos]

I guess the static analyser doesn't know about the constraints on the ini_reader reader function. By the way, the expected constraints on the returned values are not documented, although they are obvious: reader fills its str argument with a NUL-terminated string, up to max_line characters including the final NUL character.

In the process, I think i have found a few assumptions in the code which are neither checked (with an assert() for example), nor taken into account. One such assumption would be INI_MAX_LINE > INI_INITIAL_ALLOC:

inih/ini.c

Lines 142 to 144 in f5f2c6c

	#if INI_ALLOW_REALLOC && !INI_USE_STACK
	while (offset == max_line - 1 && line[offset - 1] != '\n') {
	max_line *= 2;

To cope with INI_MAX_LINE <= INI_INITIAL_ALLOC, I believe the above code should be changed to:

#if INI_ALLOW_REALLOC && !INI_USE_STACK
        while (max_line < INI_MAX_LINE && offset == max_line - 1 && line[offset - 1] != '\n') {
             max_line *= 2;