Skip to content

Make /notes/:guid work better with other clients #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make /notes/:guid work better with other clients #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 33 additions & 25 deletions routes/public.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,36 +163,44 @@ router.get('/feed', async (req, res) => {

router.get('/notes/:guid', async (req, res) => {
let guid = req.params.guid;

if (!guid) {
return res.status(400).send('Bad request.');
} else {
const actor = ActivityPub.actor;
const note = await getNote(`https://${ DOMAIN }/m/${ guid }`);
if (note === undefined) {
return res.status(404).send(`No record found for ${guid}.`);
} else {

const notes = await unrollThread(note.id);
notes.sort((a, b) => {
const ad = new Date(a.note.published).getTime();
const bd = new Date(b.note.published).getTime();
if (ad > bd) {
return 1;
} else if (ad < bd) {
return -1;
try {
const note = await getNote(`https://${ DOMAIN }/m/${ guid }`);
if (note === undefined) {
return res.status(404).send(`No record found for ${guid}.`);
} else {
return 0;
if (req.accepts('application/activity+json') && !req.accepts('*/*')) { // non-browser client
res.setHeader('Content-Type', 'application/activity+json');
res.status(200).send(note);
} else {
const notes = await unrollThread(note.id);
notes.sort((a, b) => {
const ad = new Date(a.note.published).getTime();
const bd = new Date(b.note.published).getTime();
if (ad > bd) {
return 1;
} else if (ad < bd) {
return -1;
} else {
return 0;
}
});
res.render('public/note', {
me: ActivityPub.actor,
actor: actor,
activitystream: notes,
layout: 'public',
domain: DOMAIN,
user: USERNAME
});
}
}
});
res.render('public/note', {
me: ActivityPub.actor,
actor: actor,
activitystream: notes,
layout: 'public',
domain: DOMAIN,
user: USERNAME
});
} catch(err) {
res.status(404).send();
}
}
});
});