Skip to content

Conversation

djhmateer
Copy link
Contributor

on ghsheet_feeder_db

@msramalho
Copy link
Contributor

will review next week

Comment on lines +144 to +154
if val and gw.col_exists(col):
existing_value = gw.get_cell(row_values, col)
if existing_value:
if self.allow_overwrite_of_spreadsheet_cells:
logger.info(f"Overwriting spreadsheet cell {col}={existing_value} with {final_value}")
else:
logger.warning(f"NOT overwriting spreadsheet cell {col}={existing_value} with {final_value}")
return
else:
logger.info(f"No existing value for {col}")

Copy link
Contributor

@msramalho msramalho Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change feels way too verbose, I don't feel it's useful to have new logs that simply say "this cell is empty" for every cell in a row of cells, so multiple entries per archive. Proposal keeps new logic with current level of verbosity.

Suggested change
if val and gw.col_exists(col):
existing_value = gw.get_cell(row_values, col)
if existing_value:
if self.allow_overwrite_of_spreadsheet_cells:
logger.info(f"Overwriting spreadsheet cell {col}={existing_value} with {final_value}")
else:
logger.warning(f"NOT overwriting spreadsheet cell {col}={existing_value} with {final_value}")
return
else:
logger.info(f"No existing value for {col}")
if val and gw.col_exists(col) and (gw.get_cell(row_values, col) == "" or self.allow_overwrite_of_spreadsheet_cell):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants