Add support for Datadog Service Checks #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are implemented as `last_value` metrics with `report_as: :service_check`. It does not support the "host" or "message" property, since TelemetryMetrics doesn't really seem to have a good way to express them. Fixes beam-telemetry#72
Collaborator
@jeffutter are those just tags that need to be sent with the service check event? |
Author
I don't believe they are just tags. They are additional custom fields in the statsd payload. You can see the reference here: https://docs.datadoghq.com/developers/dogstatsd/datagram_shell/?tab=servicechecks E.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are implemented as
last_valuemetrics withreport_as: :service_check. It does not support the "host" or "message" property, since TelemetryMetrics doesn't really seem to have a good way to express them.Fixes #72