Rewrite .ji contents to support tracked packages
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #5. In order to successfully use a mount cache for
.jifiles which contains portable.jifiles we parse and rewrite the local paths within the.jifiles to avoid invalidation due to only a path change. As the slug based filename is based upon a unique path name based upon the vcontent hash this works across multiple Docker images which use different versions of a tracked path package but use the same local directory.We did look at this approach as part of #5 but chose another option due to this approach requiring duplicating internal logic. We already encountered a scenario with this approach where a breaking
.jichange did not bump the.jiversion.