Skip to content

Conversation

omus
Copy link
Member

@omus omus commented Sep 14, 2023

Minor cleanup. Depends on PR: beacon-biosignals/ray#9.

Note that if beacon-biosignals/ray#9 is merged prior to this PR being merged then start_worker() will break as we currently require this unused argument.

@omus omus self-assigned this Sep 14, 2023
@omus omus marked this pull request as draft September 14, 2023 17:26
@omus
Copy link
Member Author

omus commented Sep 14, 2023

Turns out that if the backend still passes in the argument then our tests here will hang as the workers never come up due to:

too many arguments
usage: <PROGRAM> [--ray_raylet_socket_name RAYLET_SOCKET]
                 [--ray_plasma_store_socket_name STORE_SOCKET]
                 [--ray_address ADDRESS]
                 [--ray_node_manager_port NODE_MANAGER_PORT]
                 --ray_node_ip_address NODE_IP_ADDRESS
                 [--ray_redis_password REDIS_PASSWORD]
                 [--ray_session_dir SESSION_DIR]
                 [--ray_logs_dir LOGS_DIR]
                 [--runtime-env-hash RUNTIME_ENV_HASH]
                 [--startup_token STARTUP_TOKEN]

I'll make an additional PR to make this argument optional so we can have a nice clean merge order

@omus omus marked this pull request as ready for review September 14, 2023 20:14
@omus omus requested a review from glennmoy September 14, 2023 20:14
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #117 (75cf134) into main (b967b8a) will increase coverage by 0.18%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   74.44%   74.63%   +0.18%     
==========================================
  Files           8        8              
  Lines         407      406       -1     
==========================================
  Hits          303      303              
+ Misses        104      103       -1     
Flag Coverage Δ
Ray.jl 74.63% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/runtime.jl 54.01% <ø> (+0.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@omus omus merged commit 03fda94 into main Sep 15, 2023
@omus omus deleted the cv/remove-worker-arg branch September 15, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants