Skip to content

Conversation

kimlaberinto
Copy link
Member

@kimlaberinto kimlaberinto commented Jan 31, 2022

PR to update CI using the recommendation from julia-processcoverage README.

julia-action/julia-uploadcodecov is deprecated as mentioned here. The recommendation is to use julia-actions/julia-processcoverage in combination with codecov/codecov-action.

Note to self: as mentioned in https://github.com/codecov/codecov-action#usage , the secrets token is not required for public repos.

  • Assuming tests pass then this should be good to go

PR to update CI using the recommendation from [julia-processcoverage README](https://github.com/julia-actions/julia-processcoverage).

`julia-action/julia-uploadcodecov` is deprecated as mentioned [here](https://github.com/julia-actions/julia-uploadcodecov). The recommendation is to use `julia-actions/julia-processcoverage` in combination with `codecov/codecov-action`.

Note to self: as mentioned in https://github.com/codecov/codecov-action#usage , the secrets token is not required for public repos.

- [ ] Assuming tests pass then this should be good to go
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #3 (6420d3c) into main (51b40eb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            8         9    +1     
=========================================
+ Hits             8         9    +1     
Impacted Files Coverage Δ
src/PyFOOOF.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b40eb...6420d3c. Read the comment docs.

Copy link
Member

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kimlaberinto

@palday palday merged commit bcce447 into main Jan 31, 2022
@palday palday deleted the kpl/update-ci branch January 31, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants