Skip to content

Conversation

beeequeue
Copy link
Contributor

This PR replaces minimatch with picomatch as asked about in #171.

picomatch is at worst twice as fast, and at best magnitudes faster than minimatch, while also being 1/4th the size on disk.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (b8d3ded) to head (74201f5).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   95.93%   96.14%   +0.20%     
==========================================
  Files          35       35              
  Lines        2142     2126      -16     
==========================================
- Hits         2055     2044      -11     
+ Misses         87       82       -5     
Flag Coverage Δ
macos-latest-18 ?
macos-latest-20 96.05% <100.00%> (?)
macos-latest-23 96.05% <100.00%> (?)
macos-latest-lts/* 96.05% <100.00%> (+0.20%) ⬆️
ubuntu-latest-18 ?
ubuntu-latest-20 95.66% <100.00%> (?)
ubuntu-latest-23 95.66% <100.00%> (?)
ubuntu-latest-lts/* 95.66% <100.00%> (+0.20%) ⬆️
windows-latest-18 ?
windows-latest-20 95.68% <100.00%> (?)
windows-latest-23 95.68% <100.00%> (?)
windows-latest-lts/* 95.68% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @beeequeue

@bcomnes bcomnes merged commit 4f42923 into bcomnes:master May 16, 2025
17 checks passed
@beeequeue beeequeue deleted the picomatch branch May 16, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants