added servlets for IMG pt2 #80
Conversation
| for (BlobKey blobK : blobKeys) { | ||
| ServingUrlOptions options = ServingUrlOptions.Builder.withBlobKey(blobK); | ||
| try { | ||
| // getting the image URL to the uploaded file |
There was a problem hiding this comment.
nit: Capitalize the first letter of your comments.
// Getting the image URL to the uploaded file
| System.out.printf("[%s] seems to be an image, url is %s%n", blobK, imageUrl); | ||
| imageBlobUrls.add(imageUrl); | ||
| } catch (java.lang.IllegalArgumentException exception) { | ||
| // not image file -> do not add to list, remove from Blobstore |
| // not image file -> do not add to list, remove from Blobstore | ||
| System.out.printf("[%s] IllegalArgumentException: %s%n", blobK, exception.getMessage()); | ||
| try { | ||
| System.out.printf("I am deleting this thing I don't believe is an image: [%s]%n", blobK); |
There was a problem hiding this comment.
Logs should use Logger and not System.out.printf. See https://cloud.google.com/appengine/docs/standard/java/logs/
| imageBlobUrls.add(imageUrl); | ||
| } catch (java.lang.IllegalArgumentException exception) { | ||
| // not image file -> do not add to list, remove from Blobstore | ||
| System.out.printf("[%s] IllegalArgumentException: %s%n", blobK, exception.getMessage()); |
There was a problem hiding this comment.
Logs should use Logger and not System.out.printf. See https://cloud.google.com/appengine/docs/standard/java/logs/
| try { | ||
| // getting the image URL to the uploaded file | ||
| String imageUrl = imagesService.getServingUrl(options); | ||
| System.out.printf("[%s] seems to be an image, url is %s%n", blobK, imageUrl); |
There was a problem hiding this comment.
Logs should use Logger and not System.out.printf. See https://cloud.google.com/appengine/docs/standard/java/logs/
| System.out.printf("[%s] seems to be an image, url is %s%n", blobK, imageUrl); | ||
| imageBlobUrls.add(imageUrl); | ||
| } catch (java.lang.IllegalArgumentException exception) { | ||
| // not image file -> do not add to list, remove from Blobstore |
There was a problem hiding this comment.
capitalize first letter of comment.
| // User submitted form without selecting a file, so we can't get a URL. | ||
| // (devserver) | ||
| if (blobKeys == null || blobKeys.isEmpty()) { | ||
| System.out.printf( |
There was a problem hiding this comment.
Logs should use Logger and not System.out.printf. See https://cloud.google.com/appengine/docs/standard/java/logs/
| // not image file -> do not add to list, remove from Blobstore | ||
| System.out.printf("[%s] IllegalArgumentException: %s%n", blobK, exception.getMessage()); | ||
| try { | ||
| System.out.printf("I am deleting this thing I don't believe is an image: [%s]%n", blobK); |
There was a problem hiding this comment.
Logs should use Logger and not System.out.printf. See https://cloud.google.com/appengine/docs/standard/java/logs/
| System.out.printf("I am deleting this thing I don't believe is an image: [%s]%n", blobK); | ||
| blobstoreService.delete(blobK); | ||
| } catch (Exception e) { | ||
| System.out.printf("exception when deleting: %s%n", e); |
There was a problem hiding this comment.
Logs should use Logger and not System.out.printf. See https://cloud.google.com/appengine/docs/standard/java/logs/
| response.sendRedirect("/user-page.html?user=" + user); | ||
| } | ||
|
|
||
| /** should send a get request to display img in url. */ |
There was a problem hiding this comment.
Change comment to:
/** Sends a get request to display image in URL. */
2 participants
Added the preliminary steps to complete images Part 2
Issue:#34
PR:#80