Added netstandard2.1 to the build targets #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of APIs in BouncyCastle that are conditionally enabled (such as APIs that make use of `ReadOnlySpan<T>`) when `#if NETSTANDARD2_1_OR_GREATER` evaluates to `true`. This causes issues if any library that references BouncyCastle targets netstandard2.1 (and would therefore build against the netstandard2.0 version of BC) is, itself, referenced by an app (or other library) that targets net6.0+, resulting an a "missing implementation" error. Fixes issue bcgit#447 (at least in a practical sense)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There are a number of APIs in BouncyCastle that are conditionally enabled (such as APIs that make use of
ReadOnlySpan<T>) when#if NETSTANDARD2_1_OR_GREATERevaluates totrue.This causes issues if any library that references BouncyCastle targets netstandard2.1 (and would therefore build against the netstandard2.0 version of BC) if it is itself referenced by an app (or other library) that targets net6.0+, resulting in a "missing implementation" error.
Fixes issue #447 (at least in a practical sense)
How has this been tested?
Checklist before requesting a review
See also Contributing Guidelines.