Return the number of slices processed #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pont-us
approved these changes
May 28, 2024
Member
pont-us
left a comment
pont-us
left a comment
There was a problem hiding this comment.
Approved, with a query (which might necessitate a change, depending on the answer to it).
CHANGES.md
Outdated
| @@ -1,10 +1,13 @@ | |||
| ## Version 0.7.1 (in development) | |||
| ## Version 0.7.1 (from 2024-05-28) | |||
Member
There was a problem hiding this comment.
Does the change from "in development" to "from 2024-05-28" mean that this commit corresponds to the 0.7.1 release? If so, the version number in __init__.py should lose the .dev0 suffix.
Member
Author
There was a problem hiding this comment.
No, you are right, it should remain in development. There is no 0.7.1 release yet, but I planned it today, but now we have #97.
| # https://opensource.org/licenses/MIT. | ||
|
|
||
| __version__ = "0.8.0.dev0" | ||
| __version__ = "0.7.1.dev0" |
Member
There was a problem hiding this comment.
I'm not sure if the .dev0 should be here -- see comment on CHANGES.md above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
zappend.api.zappend()now returns the number of slices processed.Closes #93
Checklist (strike out non-applicable):
CHANGES.mdCHANGES.mdChanges/features documented indocs/*