Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Mar 9, 2024

Closes #77

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@codecov
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (e7c3ce3) to head (903e91f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          30       30           
  Lines        1419     1428    +9     
=======================================
+ Hits         1418     1427    +9     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman self-assigned this Mar 10, 2024
@forman forman marked this pull request as ready for review March 11, 2024 11:39
@forman forman merged commit f67c6eb into main Mar 12, 2024
@forman forman deleted the forman-77-null_chunk_sizes branch March 12, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow fixed dimensions to not be chunked

2 participants