Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Feb 23, 2024

Fixed rollback for situations where writing to Zarr fails shortly after the Zarr directory has been created.

Closes #69

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman self-assigned this Feb 23, 2024
@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (b75706a) to head (9b5bfa7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          26       26           
  Lines        1371     1372    +1     
=======================================
+ Hits         1369     1370    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman requested a review from thomasstorm February 23, 2024 13:28
Copy link
Contributor

@thomasstorm thomasstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, and additionally clearer than before.

@forman
Copy link
Member Author

forman commented Feb 23, 2024

Thanks @thomasstorm!

@forman forman merged commit f0401f6 into main Feb 23, 2024
@forman forman deleted the forman-69-rollback_fix branch February 23, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rollback may fail at times

3 participants