Skip to content

Conversation

@b-yogesh
Copy link
Collaborator

Addresses #41

@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.03%. Comparing base (75f9f37) to head (bbb32fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   88.70%   89.03%   +0.32%     
==========================================
  Files          80       82       +2     
  Lines        1355     1395      +40     
  Branches      200      205       +5     
==========================================
+ Hits         1202     1242      +40     
  Misses        124      124              
  Partials       29       29              
Flag Coverage Δ
backend 100.00% <100.00%> (ø)
frontend 76.31% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@b-yogesh b-yogesh marked this pull request as ready for review December 23, 2024 11:47
@b-yogesh b-yogesh requested a review from forman December 23, 2024 11:47
@b-yogesh b-yogesh self-assigned this Dec 23, 2024
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny suggestion, else fine!

b-yogesh and others added 3 commits February 25, 2025 10:18
# Conflicts:
#	chartlets.js/CHANGES.md
#	chartlets.js/packages/lib/src/plugins/mui/index.ts
#	chartlets.py/CHANGES.md
@b-yogesh b-yogesh requested a review from forman February 25, 2025 09:44
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, note that we actually don't need to export component prop interfaces if not explicitly needed.

@b-yogesh b-yogesh merged commit 49014f4 into main Feb 25, 2025
9 checks passed
@b-yogesh b-yogesh deleted the yogesh-41-dialog branch February 25, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants