-
Notifications
You must be signed in to change notification settings - Fork 0
Add Dialog component
#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 88.70% 89.03% +0.32%
==========================================
Files 80 82 +2
Lines 1355 1395 +40
Branches 200 205 +5
==========================================
+ Hits 1202 1242 +40
Misses 124 124
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tiny suggestion, else fine!
Co-authored-by: Norman Fomferra <[email protected]>
# Conflicts: # chartlets.js/CHANGES.md # chartlets.js/packages/lib/src/plugins/mui/index.ts # chartlets.py/CHANGES.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, note that we actually don't need to export component prop interfaces if not explicitly needed.
Addresses #41