Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Dec 18, 2024

Addresses #41

@forman forman requested a review from b-yogesh December 18, 2024 17:24
@forman forman marked this pull request as ready for review December 18, 2024 17:24
@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (46eeb85) to head (73303c2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   87.76%   87.92%   +0.16%     
==========================================
  Files          76       78       +2     
  Lines        1267     1284      +17     
  Branches      197      198       +1     
==========================================
+ Hits         1112     1129      +17     
  Misses        126      126              
  Partials       29       29              
Flag Coverage Δ
backend 100.00% <100.00%> (ø)
frontend 75.43% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Requested one change about the conditional rendering of children.

@b-yogesh b-yogesh assigned b-yogesh and unassigned b-yogesh Dec 23, 2024
@forman forman merged commit 5957305 into main Jan 14, 2025
4 checks passed
@forman forman deleted the forman-41-Divider branch January 14, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants