Skip to content

Changed the yet unused descriptor type CbFunction #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
forman merged 2 commits into from
Dec 7, 2024
Merged

Changed the yet unused descriptor type CbFunction #67

forman merged 2 commits into from
Dec 7, 2024

Conversation

@forman
Copy link
Member

@forman forman commented Dec 7, 2024

  • using schema instead of type property for callback arguments
  • using return object with schema for callback return values

@forman
Changed the yet unused descriptor type CbFunction for callback func…
e190419 
…tions.
@forman
Merge branch 'main' into forman-x-callback_function_descriptor
ced52de 
# Conflicts:
#	chartlets.js/CHANGES.md
#	chartlets.js/package.json
#	chartlets.py/CHANGES.md
#	chartlets.py/chartlets/version.py
@forman forman requested a review from b-yogesh December 7, 2024 16:23
@forman forman self-assigned this Dec 7, 2024
@forman forman marked this pull request as ready for review December 7, 2024 16:23
forman
forman commented Dec 7, 2024
View reviewed changes
Copy link
Member Author

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@forman forman merged commit e3b88f2 into main Dec 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b-yogesh b-yogesh Awaiting requested review from b-yogesh

Assignees

@forman forman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@forman