-
Notifications
You must be signed in to change notification settings - Fork 0
Split lib and demo #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_providers # Conflicts: # chartlets.py/CHANGES.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS
Reorganised Chartlets project to better separate demo from library code.
Using monorepo layout for
chartlets.jswith workspaceslibanddemothat host the packages for
chartletsandchartlets-demo.Chartlets now allows for plugins that can provide individual component
implementations.
The Vega-based chart and MUI components are now optional and have been
moved into respective plugin modules
chartlets/plugins/vegaandchartlets/plugins/mui.To activate them, use the new
plugins: PluginLike[]optionof
FrameworkOptions:Renamed
Plotcomponent intoVegaChart.The new
VegaChartcomponent respects athemeproperty. If not given,it will respect the current theme mode
"dark"otherwise fallback to theVega default theme.
The demo application now allows for switching the theme mode between
dark, light, and system mode.
Python
Reorganised Chartlets project to better separate demo from library code.
Created separate folder
demoinchartlets.pythat containsa demo
serverpackage and example configuration.Also simplified demo server code:
panelmodule one level uputilmodule which was no longer requiredAllow for different chart providers.
VegaChartcan be configured only ifaltairpackage is installed.Renamed
PlotintoVegaChart, which now also respects athemeproperty.