Skip to content

Apply styles correctly in RadioGroup component #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forman merged 2 commits into from
Jun 17, 2025
Merged

Apply styles correctly in RadioGroup component #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f187ef
change where `style` is applied
b-yogesh Jun 6, 2025
52e1bef
update CHANGES.md
b-yogesh Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions chartlets.js/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* Implemented dynamic resizing for Vega Charts when the side panel's
width changes.
See https://github.com/xcube-dev/xcube/issues/1134

* Styles are now correctly applied to `RadioGroup` component.

## Version 0.1.5 (from 2025/03/21)

Expand Down
5 changes: 3 additions & 2 deletions chartlets.js/packages/lib/src/plugins/mui/RadioGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import MuiFormControlLabel from "@mui/material/FormControlLabel";
import MuiFormLabel from "@mui/material/FormLabel";
import { Tooltip } from "./Tooltip";

import type { ComponentState, ComponentProps } from "@/index";
import type { ComponentProps, ComponentState } from "@/index";

interface RadioState extends ComponentState {
type: "Radio";
Expand Down Expand Up @@ -54,13 +54,14 @@ export function RadioGroup({
};
return (
<Tooltip title={tooltip}>
<MuiFormControl style={style} disabled={disabled}>
<MuiFormControl disabled={disabled}>
<MuiFormLabel>{label}</MuiFormLabel>
<MuiRadioGroup
id={id}
name={name}
row={row}
value={value}
style={style}
onChange={handleChange}
>
{radioButtons &&
Expand Down